Refactor adapters #256

Merged

kinggoesgaming merged 10 commits from adapters into breaking

2018-06-26 01:49:54 -05:00

kinggoesgaming commented

2018-06-01 22:08:15 -05:00

(Migrated from github.com)

Currently in a hurry, will expand the description tomorrow or so.
Also these changes particularly around the to_<adaptertype> method names need discussion before merge

I'm submitting a ...

bug fix
feature enhancement
deprecation or removal
refactor

Description

Refactors the adapters

Motivation

One of the last steps in the great refactor

Tests

Current tests pass.... More tests need to be added

#124

Currently in a hurry, will expand the description tomorrow or so. Also these changes particularly around the `to_<adaptertype>` method names need discussion before merge **I'm submitting a ...** - [ ] bug fix - [x] feature enhancement - [ ] deprecation or removal - [x] refactor # Description Refactors the adapters # Motivation One of the last steps in the great refactor # Tests Current tests pass.... More tests need to be added # Related Issue(s) #124

radix (Migrated from github.com) reviewed

2018-06-01 22:08:15 -05:00

KodrAus (Migrated from github.com) reviewed

2018-06-01 22:08:15 -05:00

todo[bot] commented

2018-06-01 22:08:22 -05:00

(Migrated from github.com)

documentation

github.com/uuid-rs/uuid@bc82020988/src/adapter/mod.rs (L35-L40)

This comment was generated by todo based on a `TODO` comment in `bc82020988` in #256. cc @uuid-rs.

## documentation https://github.com/uuid-rs/uuid/blob/bc82020988e8dd91df1092d11ac079118e110d52/src/adapter/mod.rs#L35-L40 --- ###### This comment was generated by [todo](https://todo.jasonet.co) based on a `TODO` comment in bc82020988e8dd91df1092d11ac079118e110d52 in #256. cc @uuid-rs.

kinggoesgaming commented

2018-06-25 21:10:49 -05:00

(Migrated from github.com)

I intend on opening another PR for serde implementations for the adapters in the future.

As such I consider this PR ready for review

I intend on opening another PR for `serde` implementations for the adapters in the future. As such I consider this PR ready for review

kinggoesgaming commented

2018-06-25 21:33:28 -05:00

(Migrated from github.com)

One question I have is that I have added many #[inline] where I thought it would ideal to inline the functions. But I know that the attribute might override the compiler is some cases where this may actually generate slower/ worse asm... opinions?

One question I have is that I have added many `#[inline]` where I thought it would ideal to inline the functions. But I know that the attribute might override the compiler is some cases where this may actually generate slower/ worse asm... opinions?

Dylan-DPC-zz (Migrated from github.com) approved these changes

2018-06-26 01:27:43 -05:00

Dylan-DPC-zz (Migrated from github.com) approved these changes

2018-06-26 01:43:16 -05:00

Dylan-DPC-zz commented

2018-06-26 01:43:35 -05:00

(Migrated from github.com)

bors: r+

bors[bot] commented

2018-06-26 01:49:54 -05:00

(Migrated from github.com)

Build succeeded

# Build succeeded * [continuous-integration/travis-ci/push](https://travis-ci.org/uuid-rs/uuid/builds/396733554?utm_source=github_status&utm_medium=notification) * [continuous-integration/appveyor/branch](https://ci.appveyor.com/project/KodrAus/uuid/build/1.0.746)