Introduce UuidParseError #286

2018-07-25T17:43:04-05:00

kinggoesgaming commented

2018-07-25 17:43:04 -05:00

(Migrated from github.com)

I'm submitting a(n) feature,refactor

Description

Replace ParseError with UuidParseError

Motivation

Currently, the context for the errors around uuid string is limited to hyphenated, integer, simple and urn formats. This expands the error layout so that the context is more generic so nonstandard formats can use our error type for custom uuids.

Tests

Fix current tests to match the new signature. No new tests added

closes #276

**I'm submitting a(n)** feature,refactor # Description Replace ParseError with UuidParseError # Motivation Currently, the context for the errors around uuid string is limited to hyphenated, integer, simple and urn formats. This expands the error layout so that the context is more generic so nonstandard formats can use our error type for custom uuids. # Tests Fix current tests to match the new signature. No new tests added # Related Issue(s) closes #276

radix (Migrated from github.com) reviewed

2018-07-25 17:43:04 -05:00

KodrAus (Migrated from github.com) reviewed

2018-07-25 17:43:04 -05:00

todo[bot] commented

2018-07-25 17:43:10 -05:00

(Migrated from github.com)

explain multiple segment count.

Parsers can expect a range of Uuid segment count.

github.com/uuid-rs/uuid@1be44122d8/src/parser/mod.rs (L62-L67)

This comment was generated by todo based on a `TODO` comment in `1be44122d8` in #286. cc @uuid-rs.

## explain multiple segment count. Parsers can expect a range of Uuid segment count. --- https://github.com/uuid-rs/uuid/blob/1be44122d85480fa98eeed5b9fa8097420d30bf2/src/parser/mod.rs#L62-L67 --- ###### This comment was generated by [todo](https://todo.jasonet.co) based on a `TODO` comment in 1be44122d85480fa98eeed5b9fa8097420d30bf2 in #286. cc @uuid-rs.

todo[bot] commented

2018-07-26 18:21:59 -05:00

(Migrated from github.com)

remove the u8 cast

this only needed until we switch to

github.com/uuid-rs/uuid@ec26b6051f/src/lib.rs (L173-L178)

This comment was generated by todo based on a `TODO` comment in `ec26b6051f` in #286. cc @uuid-rs.

## remove the u8 cast this only needed until we switch to --- https://github.com/uuid-rs/uuid/blob/ec26b6051f60abdd1cc499d2a5f16eb32c05f68a/src/lib.rs#L173-L178 --- ###### This comment was generated by [todo](https://todo.jasonet.co) based on a `TODO` comment in ec26b6051f60abdd1cc499d2a5f16eb32c05f68a in #286. cc @uuid-rs.

Dylan-DPC-zz (Migrated from github.com) requested changes

2018-07-31 01:09:20 -05:00

src/parser/core_support.rs

					
				@ -0,0 +9,4 @@

				// option. This file may not be copied, modified, or distributed

				// except according to those terms.

				use core::fmt;

you don't need the <'a> on impl

you don't need the `<'a>` on impl

kinggoesgaming (Migrated from github.com) reviewed

2018-07-31 12:36:35 -05:00

src/parser/core_support.rs

					
				@ -0,0 +9,4 @@

				// option. This file may not be copied, modified, or distributed

				// except according to those terms.

				use core::fmt;

oops

kinggoesgaming commented

2018-08-07 22:29:54 -05:00

(Migrated from github.com)

@Dylan-DPC ready for review + merge

Dylan-DPC-zz (Migrated from github.com) reviewed

2018-08-08 02:28:12 -05:00

Dylan-DPC-zz (Migrated from github.com) approved these changes

2018-08-08 06:16:30 -05:00

Dylan-DPC-zz commented

2018-08-08 06:31:29 -05:00

(Migrated from github.com)

bors: r+

bors[bot] commented

2018-08-08 06:38:47 -05:00

(Migrated from github.com)

Build succeeded

# Build succeeded * [continuous-integration/travis-ci/push](https://travis-ci.org/uuid-rs/uuid/builds/413536599?utm_source=github_status&utm_medium=notification) * [continuous-integration/appveyor/branch](https://ci.appveyor.com/project/KodrAus/uuid/build/1.0.828)

Sign in to join this conversation.

No reviewers

radix

KodrAus

Dylan-DPC-zz