gh-uuid-rs/uuid

Watch

Fork 0

Split up parse_str.rs file #236 #308

Merged

murrayjbrown merged 3 commits from develop into master

2018-09-02 07:19:39 -05:00

murrayjbrown commented

2018-09-01 18:24:44 -05:00

(Migrated from github.com)

I'm submitting a refactor for issue #236 - Split up parse_str.rs file.

Description

The file bench/parse_str.rs has been refactored into:

valid_parse_str.rs
invalid_parse_str.rs
slog_support/parse_str.rs

The test case bench_parse() has been split into bench_parse_invalid_strings() or bench_parse_valid_strings(), accordingly, for its respective test file;

Additionally, the test case bench_log_discard_kv() in slog_support/parse_str.rs has been revised to produce benchmark results, which (for some reason) it did not previously.

Motivation

Benchmarking file becoming too large.

Tests

Benchmark test results should display test cases grouped according to description above. Attached are results for benchmark tests run before and after this refactoring:

#236

**I'm submitting a refactor for issue #236 - Split up parse_str.rs file.** # Description The file _bench/parse_str.rs_ has been refactored into: > valid_parse_str.rs > invalid_parse_str.rs > slog_support/parse_str.rs The test case `bench_parse()` has been split into `bench_parse_invalid_strings()` or `bench_parse_valid_strings()`, accordingly, for its respective test file; Additionally, the test case `bench_log_discard_kv()` in _slog_support/parse_str.rs_ has been revised to produce benchmark results, which (for some reason) it did not previously. # Motivation Benchmarking file becoming too large. # Tests Benchmark test results should display test cases grouped according to description above. Attached are results for benchmark tests run _before_ and _after_ this refactoring: * [uuid_bench_before.txt](https://github.com/uuid-rs/uuid/files/2342840/uuid_bench_before.txt) * [uuid_bench_after.txt](https://github.com/uuid-rs/uuid/files/2342839/uuid_bench_after.txt) # Related Issue(s) #236

radix (Migrated from github.com) reviewed

2018-09-01 18:24:44 -05:00

KodrAus (Migrated from github.com) reviewed

2018-09-01 18:24:44 -05:00

kinggoesgaming (Migrated from github.com) reviewed

2018-09-01 18:24:44 -05:00

kinggoesgaming commented

2018-09-02 00:08:26 -05:00

(Migrated from github.com)

@murrayjbrown thanks again for the working on this!! Can you run cargo +nightly fmt using the latest nightly?

@murrayjbrown thanks again for the working on this!! Can you run `cargo +nightly fmt` using the latest nightly?

Dylan-DPC-zz (Migrated from github.com) approved these changes

2018-09-02 07:11:19 -05:00

Dylan-DPC-zz commented

2018-09-02 07:11:55 -05:00

(Migrated from github.com)

Thanks @murrayjbrown

bors: r+

Thanks @murrayjbrown bors: r+

bors[bot] commented

2018-09-02 07:19:39 -05:00

(Migrated from github.com)

Build succeeded

# Build succeeded * [continuous-integration/appveyor/branch](https://ci.appveyor.com/project/KodrAus/uuid/build/1.0.919) * [continuous-integration/travis-ci/push](https://travis-ci.org/uuid-rs/uuid/builds/423592623?utm_source=github_status&utm_medium=notification)

murrayjbrown commented

2018-09-02 12:42:24 -05:00

(Migrated from github.com)

@kinggoesgaming I'm hoping that's now a rhetorical question about cargo fmt as the issue has been closed but I'll be sure to do so in the future.

Thanks to both you and @Dylan-DPC ! This has been a great intro to Rust. :-)

@kinggoesgaming I'm hoping that's now a rhetorical question about `cargo fmt` as the issue has been closed but I'll be sure to do so in the future. Thanks to both you and @Dylan-DPC ! This has been a great intro to Rust. :-)

👍 1 🎉 1

Dylan-DPC-zz commented

2018-09-02 12:47:43 -05:00

(Migrated from github.com)

@murrayjbrown yeah you don't have to bother about it since I pulled in your fork and ran fmt since it is trivial enough and didn't want to wait for you 😄

Thanks for the PR. Looking forward to more collaboration from you 👍

@murrayjbrown yeah you don't have to bother about it since I pulled in your fork and ran fmt since it is trivial enough and didn't want to wait for you :smile: Thanks for the PR. Looking forward to more collaboration from you :+1: