Cleanup the code #339

Merged
kinggoesgaming merged 5 commits from cleanup into master 2018-10-09 08:40:26 -05:00
kinggoesgaming commented 2018-10-08 18:39:34 -05:00 (Migrated from github.com)

I'm submitting a(n) refactor

Description

Used clippy on stable channel for most features (except guid, since I don't have windows available)

Motivation

Will be creating another PR that closes #282. But wanted to catch the current issues before doing that

Tests

Current tests pass. No new tests needed

Related Issue(s)

N/A

**I'm submitting a(n)** refactor # Description Used clippy on stable channel for most features (except guid, since I don't have windows available) # Motivation Will be creating another PR that closes #282. But wanted to catch the current issues before doing that # Tests Current tests pass. No new tests needed # Related Issue(s) N/A
Dylan-DPC-zz (Migrated from github.com) approved these changes 2018-10-09 08:29:02 -05:00
Dylan-DPC-zz commented 2018-10-09 08:29:46 -05:00 (Migrated from github.com)

bors: r+

bors: r+
bors[bot] commented 2018-10-09 08:40:25 -05:00 (Migrated from github.com)
# Build succeeded * [continuous-integration/travis-ci/push](https://travis-ci.org/uuid-rs/uuid/builds/439138482?utm_source=github_status&utm_medium=notification) * [continuous-integration/appveyor/branch](https://ci.appveyor.com/project/KodrAus/uuid/builds/19371203)
KodrAus (Migrated from github.com) reviewed 2018-10-14 19:51:16 -05:00
@ -238,1 +237,3 @@
let b = bytes[idx];
for (idx, b) in bytes
.iter()
.enumerate()
KodrAus (Migrated from github.com) commented 2018-10-14 19:51:16 -05:00

@kinggoesgaming Curious to know whether this change results in any regression in our microbenchmarks.

@kinggoesgaming Curious to know whether this change results in any regression in our microbenchmarks.
kinggoesgaming (Migrated from github.com) reviewed 2018-10-15 10:46:51 -05:00
@ -238,1 +237,3 @@
let b = bytes[idx];
for (idx, b) in bytes
.iter()
.enumerate()
kinggoesgaming (Migrated from github.com) commented 2018-10-15 10:46:51 -05:00

hmm.. hadnt considered that.. I will have a look

hmm.. hadnt considered that.. I will have a look
Sign in to join this conversation.
No reviewers
No milestone
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gh-uuid-rs/uuid!339
No description provided.