enable adapter tests for encode_{lower, upper} #390

2019-03-31T13:55:24-05:00

kinggoesgaming commented

2019-03-31 13:55:24 -05:00

(Migrated from github.com)

I'm submitting a(n) other

Description

encode_{lower, upper} tests were not enabled when we enabled the functions.

Motivation

More tests

Tests

New tests enabled

**I'm submitting a(n)** other # Description `encode_{lower, upper}` tests were not enabled when we enabled the functions. # Motivation More tests # Tests New tests enabled # Related Issue(s)

Dylan-DPC-zz (Migrated from github.com) reviewed

2019-03-31 14:02:44 -05:00

KodrAus (Migrated from github.com) reviewed

2019-03-31 16:11:57 -05:00

src/lib.rs

				`@ -938,7 +938,7 @@ impl Uuid {`

Looks like this might be causing the build to fail in no-std environments

kinggoesgaming (Migrated from github.com) reviewed

2019-03-31 21:16:12 -05:00

src/lib.rs

				`@ -938,7 +938,7 @@ impl Uuid {`

nope... tests module always had the declaration.

I think I just have to revert the change and it should be fine

nope... tests module always had the declaration. I think I just have to revert the change and it should be fine

kinggoesgaming (Migrated from github.com) reviewed

2019-03-31 22:15:38 -05:00

src/lib.rs

				`@ -938,7 +938,7 @@ impl Uuid {`

1b46bad fixes this

1b46bad fixes this

Dylan-DPC-zz (Migrated from github.com) approved these changes

2019-04-01 01:58:44 -05:00

Dylan-DPC-zz commented

2019-04-01 02:00:07 -05:00

(Migrated from github.com)

bors: r+

bors[bot] commented

2019-04-01 02:17:44 -05:00

(Migrated from github.com)

Build succeeded

# Build succeeded * [continuous-integration/appveyor/branch](https://ci.appveyor.com/project/KodrAus/uuid/builds/23498304) * [continuous-integration/travis-ci/push](https://travis-ci.org/uuid-rs/uuid/builds/513991026?utm_source=github_status&utm_medium=notification)

Sign in to join this conversation.

No reviewers

Dylan-DPC-zz