Remove the set_version and set_variant methods #400

Merged

kinggoesgaming merged 8 commits from remove-mut-funs into master

2019-04-22 21:04:52 -05:00

kinggoesgaming commented

2019-04-20 23:55:14 -05:00

(Migrated from github.com)

I'm submitting a(n) removal

Description

Removes Uuid::set_variant and Uuid::set_version

Motivation

These methods were private and already uuid::builder::Builder was being recommended.

Tests

Current tests should pass.

N/A

**I'm submitting a(n)** removal # Description Removes `Uuid::set_variant` and `Uuid::set_version` # Motivation These methods were private and already `uuid::builder::Builder` was being recommended. # Tests Current tests should pass. # Related Issue(s) N/A

Dylan-DPC-zz (Migrated from github.com) reviewed

2019-04-20 23:55:14 -05:00

kinggoesgaming commented

2019-04-20 23:57:28 -05:00

(Migrated from github.com)

depends on #399

kinggoesgaming commented

2019-04-22 03:07:33 -05:00

(Migrated from github.com)

Ignore restyled for me

KodrAus (Migrated from github.com) reviewed

2019-04-22 18:46:38 -05:00

src/lib.rs

We should remove this before merging

kinggoesgaming (Migrated from github.com) reviewed

2019-04-22 18:57:06 -05:00

src/lib.rs

um... yea... I made a mistake during the refactor and couldn't figure out where was fail happening (cuz there are multiple asserts)

doing it rn

um... yea... I made a mistake during the refactor and couldn't figure out where was fail happening (cuz there are multiple asserts) doing it rn

KodrAus (Migrated from github.com) approved these changes

2019-04-22 20:45:53 -05:00

KodrAus (Migrated from github.com) left a comment

Looks good to me!

KodrAus commented

2019-04-22 20:46:01 -05:00

(Migrated from github.com)

bors r+

bors[bot] commented

2019-04-22 21:04:52 -05:00

(Migrated from github.com)

Build succeeded

# Build succeeded * [continuous-integration/appveyor/branch](https://ci.appveyor.com/project/KodrAus/uuid/builds/24029062) * [continuous-integration/travis-ci/push](https://travis-ci.org/uuid-rs/uuid/builds/523277613?utm_source=github_status&utm_medium=notification)