gh-uuid-rs/uuid
Watch
1
0
Fork
You've already forked uuid
 0
Code Issues 10 Pull requests 2 Releases Activity

Update to getrandom:0.2.0 #501

Merged
CAD97 merged 2 commits from master into master 2020-12-21 01:15:24 -06:00
Conversation 8 Commits 2 Files changed 6 +9 -9
CAD97 commented 2020-12-20 21:48:40 -06:00 (Migrated from github.com)

I'm submitting a(n) other

Description

Update getrandom to v0.2.0.

This raises the MSRV to getrandom's, 1.34.0.

Motivation

Use the latest version of upstream.

Tests

N/A

Related Issue(s)

  • #475: It'd be great to have a new release that uses getrandom instead of rand, especially since a new version of rand is out as well. (NB: the change to new_v4 from returning Self to returning Result<Self, _> is, of course, breaking, and will mean releasing the new version as uuid:0.9.)
  • closes #494: the @dependabot-bot version of this PR. Failing due to not updating the MSRV.
<!-- If this PR is a breaking change, ensure that you are opening it against the `breaking` branch. If the pull request is incomplete, prepend the Title with WIP: --> **I'm submitting a(n)** other # Description Update getrandom to v0.2.0. This raises the MSRV to getrandom's, 1.34.0. # Motivation Use the latest version of upstream. # Tests N/A # Related Issue(s) - #475: It'd be great to have a new release that uses `getrandom` instead of `rand`, especially since a new version of `rand` is out as well. (NB: the change to `new_v4` from returning `Self` to returning `Result<Self, _>` is, of course, breaking, and will mean releasing the new version as `uuid:0.9`.) - closes #494: the @dependabot-bot version of this PR. Failing due to not updating the MSRV.
Dylan-DPC-zz (Migrated from github.com) reviewed 2020-12-20 21:48:40 -06:00
kinggoesgaming (Migrated from github.com) reviewed 2020-12-20 21:48:40 -06:00
KodrAus commented 2020-12-20 23:17:03 -06:00 (Migrated from github.com)

This looks good to me too. The version bump to 1.34.0 is also reasonable.

This looks good to me too. The version bump to `1.34.0` is also reasonable.
KodrAus (Migrated from github.com) approved these changes 2020-12-20 23:17:11 -06:00
KodrAus commented 2020-12-20 23:17:17 -06:00 (Migrated from github.com)

bors r+

bors r+
KodrAus commented 2020-12-21 00:02:21 -06:00 (Migrated from github.com)

Wanna give that another go?

bors r+

Wanna give that another go? bors r+
KodrAus commented 2020-12-21 00:53:03 -06:00 (Migrated from github.com)

bors r+

bors r+
KodrAus commented 2020-12-21 00:55:51 -06:00 (Migrated from github.com)

Looks like bors is having a bit of a bad time so I'll merge this one manually.

Looks like bors is having a bit of a bad time so I'll merge this one manually.
Sign in to join this conversation.
Reviewers
No reviewers
Dylan-DPC-zz
kinggoesgaming
KodrAus
Labels
Clear labels   
breaking
This causes a breaking change and will be merged to breaking branch.

  
bug

   
dependencies
Pull requests that update a dependency file

  
good first issue

   
help wanted

   
unstable
Tracking issue for an unstable optional dependency

No labels
breaking
bug
dependencies
good first issue
help wanted
unstable
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
gh-uuid-rs/uuid!501
No description provided.