miles/cctools-port
1
0
Fork 0
Code Issues 22 Pull requests 5 Releases 10 Activity

ld64: Swap LTO_RPATH to LTO_LIB - Fixes LTO on macOS #121

Open
Gcenx wants to merge 1 commit from Gcenx/patch-1 into master
pull from: Gcenx/patch-1
merge into: miles:master
Conversation 2 Commits 1 Files changed 2 +2 -2
Gcenx commented 2022-03-19 12:19:39 -05:00 (Migrated from github.com)
Copy link

Fixes LTO linking on macOS this follows what's done with other libraries in ld_LDADD section

Closes #120

Fixes LTO linking on macOS this follows what's done with other libraries in ld_LDADD section Closes #120
tpoechtrager commented 2023-08-21 13:04:37 -05:00 (Migrated from github.com)
Copy link

ld64 shouldn't link against libLTO. The library is loaded dynamically. If linking against it is indeed needed on macOS, then feel free to adjust the PR so it affects only macOS.

ld64 shouldn't link against libLTO. The library is loaded dynamically. If linking against it is indeed needed on macOS, then feel free to adjust the PR so it affects only macOS.
Gcenx commented 2023-08-21 13:10:45 -05:00 (Migrated from github.com)
Copy link

I’ll look over this again, I can’t remember if the rpath was configured correctly or not.

I’ll look over this again, I can’t remember if the rpath was configured correctly or not.
👍 1
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin Gcenx/patch-1:Gcenx/patch-1
git switch Gcenx/patch-1

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch master
git merge --no-ff Gcenx/patch-1
git switch Gcenx/patch-1
git rebase master
git switch master
git merge --ff-only Gcenx/patch-1
git switch Gcenx/patch-1
git rebase master
git switch master
git merge --no-ff Gcenx/patch-1
git switch master
git merge --squash Gcenx/patch-1
git switch master
git merge --ff-only Gcenx/patch-1
git switch master
git merge Gcenx/patch-1
git push origin master
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

   
duplicate

   
enhancement

   
invalid

   
question

   
wontfix
No labels
bug
duplicate
enhancement
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
miles/cctools-port!121
No description provided.