Avoid dead-stripping rust compiler_builtins atoms #135

2023-07-05T17:29:29-05:00

glandium commented

2023-07-05 17:29:29 -05:00

(Migrated from github.com)

No description provided.

glandium (Migrated from github.com) reviewed

2023-07-05 17:30:18 -05:00

cctools/ld64/src/ld/Resolver.cpp

					
				@ -1197,3 +1198,3 @@

							if ( isCompilerSupportLib(atom->safeFilePath()) ) {

							if ( isCompilerSupportLib(atom->safeFilePath()) || strstr(atom->safeFilePath(), "compiler_builtins") != nullptr ) ) {

								_deadStripRoots.insert(atom);

							}

Note that I didn't add this check in isCompilerSupportLib because I wasn't sure of the side effects from other code using that function.

This pull request can be merged automatically.

You are not authorized to merge this pull request.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin 'glandium/rust:glandium/rust'

git switch 'glandium/rust'

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch 'master'

git merge --no-ff 'glandium/rust'

git switch 'glandium/rust'

git rebase 'master'

git switch 'master'

git merge --ff-only 'glandium/rust'

git switch 'glandium/rust'

git rebase 'master'

git switch 'master'

git merge --no-ff 'glandium/rust'

git switch 'master'

git merge --squash 'glandium/rust'

git switch 'master'

git merge --ff-only 'glandium/rust'

git switch 'master'

git merge 'glandium/rust'

git push origin 'master'

Sign in to join this conversation.

No reviewers

No labels

No milestone

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

miles/cctools-port!135

Rows
Columns