Add dsa_wycheproof_test #291
No reviewers
Labels
No labels
bug
duplicate
enhancement
feature
help wanted
improve API
invalid
needs documentation
not-planned
rtfm
stale
support
wishlist
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
gh-libtom/libtomcrypt!291
Loading…
Reference in a new issue
No description provided.
Delete branch "pr/dsa-test-wycheproof"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
In the latest release of my libtomcrypt perl bindings (based on the latest release/1.18.0 branch) I turned on wycheproof tests (for RSA, DSA, ECDH) which mostly pass except the test
type=DSAVer/SHA224 tcId=55 comment='appending unused 0's' expected-result=invalide.g.So I have decided to add this "sometimes failing" test to libtomcrypt's
dsa_test().It passes fine on my laptop; however, travis-ci is not quite happy about it.Update: the troubles with Travis-CI turned out to be TFM related. It seems that
radix_to_bindoes not work correctly with TFM - when passed a hexadecimal string of 1676 characters it returnsCRYPT_OKbut the binary output is only 576 bytes (instead of expected 838).Anyway I am for merging this extra DSA test and see whether somebody will report a failure on ARM or not.
looks like this happened with gcc and clang...
/cc @sebastianas
Those failures happened on ARM-32bit-LE. Can anybody checkout
pr/dsa-test-wycheproofand build & run./teston this architecture?And with TFM?
Thanks, although a failure would have been more valuable in this case 😃
Ad TFM: the failures from my perl bindings are from LTC+LTM; the trouble with
radix_to_bin()was "fixed" by switching from hex to Base64. In other words TFM should be fine.mh okay
#294
I have installed
Raspbian GNU/Linux 9.1 (stretch)in QEMU:but no failure (neither with this PR nor with my perl bindings).
I'll try to contact the guys running those perl cpan smokers and ask for more details.
More info about perl bindings failure
It was Raspberry Pi 1B, running Raspbian and a perl-brewed perl 5.26.
@ksherlock I have update
pr/dsa-test-wycheproof- could you please pull the latest version and run it again?TL;DR fixed by
155e29d- let's see what's Travis' opinion.👍