pico_flash stops including certain unneeded headers #1699

Merged

jaguilar merged 1 commit from develop into develop 2024-06-04 19:59:59 -05:00

Conversation 5 Commits 1 Files changed 2 -4

jaguilar commented 2024-05-06 20:38:50 -05:00 (Migrated from github.com)

• Copy link
• Copy Markdown

Fixes #1698

Fixes #1698

kilograham commented 2024-05-19 14:59:50 -05:00 (Migrated from github.com)

• Copy link
• Copy Markdown

Yeah, we have kitchen_sink test already which pulls in all libraries to make sure they compile, so pls remove the new test

Yeah, we have `kitchen_sink` test already which pulls in all libraries to make sure they compile, so pls remove the new test

jaguilar commented 2024-05-19 17:56:35 -05:00 (Migrated from github.com)

• Copy link
• Copy Markdown

@kilograham kitchen_sink_test is already building without my change, however, the test I'm adding is not. I'm still happy to remove it, but I think kitchen_sink_test is hiding the bug by pulling in hardware_exception as a separate dependency. Just wanted to reconfirm that you want it removed even though we have no coverage of the underlying issue already.

@kilograham kitchen_sink_test is already building without my change, however, the test I'm adding is not. I'm still happy to remove it, but I think kitchen_sink_test is hiding the bug by pulling in hardware_exception as a separate dependency. Just wanted to reconfirm that you want it removed even though we have no coverage of the underlying issue already.

kilograham commented 2024-05-19 18:26:37 -05:00 (Migrated from github.com)

• Copy link
• Copy Markdown

ah good point, but yeah, i think remove it... we should add a separate (hopefully automated) check of each library

ah good point, but yeah, i think remove it... we should add a separate (hopefully automated) check of each library

jaguilar commented 2024-05-19 21:29:22 -05:00 (Migrated from github.com)

• Copy link
• Copy Markdown

Updated the state to just remove those three includes. Thank you for taking the time to review.

Updated the state to just remove those three includes. Thank you for taking the time to review.

kilograham (Migrated from github.com) approved these changes 2024-05-20 07:17:23 -05:00

Sign in to join this conversation.

Reviewers

No reviewers

kilograham

Labels

Clear labels   

bazel

  

bluetooth

  

board settings

  

boot_stage2

  

bug

Something isn't working

  

build

  

c++

  

can't reproduce

Can not reproduce the bug

  

clang

  

clib-interface

  

cmsis

  

code cleanliness

  

code size

  

compiler version issues

  

cyw43_driver

  

debug

  

discussion

  

documentation

Improvements or additions to documentation

  

duplicate

This issue or pull request already exists

  

dynamic_clock

  

elf2uf2

  

enhancement

New feature or request

  

errata

  

filesystem

  

flash layout

  

floating point

  

FreeRTOS

  

hardware_adc

  

hardware_claim

  

hardware_clocks

  

hardware_dma

  

hardware_exception

  

hardware_flash

  

hardware_gpio

  

hardware_i2c

  

hardware_irq

  

hardware_pio

  

hardware_pwm

  

hardware_rcp

  

hardware_rtc

  

hardware_spi

  

hardware_sync

  

hardware_uart

  

hardware_vreg

  

hardware_watchdog

  

hardware_xosc

  

help wanted

Extra attention is needed

  

host

  

IAR

  

installation

  

invalid

This doesn't seem right

  

linker scripts

  

lto

  

lwip

  

mbedtls

  

missing API

  

needs reporter detail

  

networking

  

newlib

  

newlib-multicore

  

non-c

  

non-cmake

  

non-gcc

  

openocd

  

orphan PR

  

OS integration

  

pico_async_context

  

pico_base

  

pico_binary_info

  

pico_flash

  

picolibc

  

pico_lwip

  

pico_malloc

  

pico_multicore

  

pico_printf

  

pico_runtime

  

pico_stdio

  

pico_stdio_usb

  

pico_sync

  

pico_time

  

pico_util

  

pioasm

  

port

issues or discussions of porting code/libraries to rp2040

  

question

Further information is requested

  

review

  

review2

  

rtos interop

Consideration for FreeRTOS co-existence

  

runtime init

  

static library

  

svd

  

test

  

tinyusb

  

vscode

  

wifi integration

  

wontfix

This will not be worked on

No labels

bazel

bluetooth

board settings

boot_stage2

bug

build

c++

can't reproduce

clang

clib-interface

cmsis

code cleanliness

code size

compiler version issues

cyw43_driver

debug

discussion

documentation

duplicate

dynamic_clock

elf2uf2

enhancement

errata

filesystem

flash layout

floating point

FreeRTOS

hardware_adc

hardware_claim

hardware_clocks

hardware_dma

hardware_exception

hardware_flash

hardware_gpio

hardware_i2c

hardware_irq

hardware_pio

hardware_pwm

hardware_rcp

hardware_rtc

hardware_spi

hardware_sync

hardware_uart

hardware_vreg

hardware_watchdog

hardware_xosc

help wanted

host

IAR

installation

invalid

linker scripts

lto

lwip

mbedtls

missing API

needs reporter detail

networking

newlib

newlib-multicore

non-c

non-cmake

non-gcc

openocd

orphan PR

OS integration

pico_async_context

pico_base

pico_binary_info

pico_flash

picolibc

pico_lwip

pico_malloc

pico_multicore

pico_printf

pico_runtime

pico_stdio

pico_stdio_usb

pico_sync

pico_time

pico_util

pioasm

port

question

review

review2

rtos interop

runtime init

static library

svd

test

tinyusb

vscode

wifi integration

wontfix

Milestone

Clear milestone

No items

No milestone

2.0.0

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

gh-raspberrypi/pico-sdk!1699

No description provided.