fix parser::Error::InvalidCharacter Display message #355

Merged

kinggoesgaming merged 3 commits from parser-error-char-fix into master

2019-01-17 19:57:46 -06:00

kinggoesgaming commented

2019-01-10 21:49:54 -06:00

(Migrated from github.com)

I'm submitting a(n) bug fix

Description

Use string instead of str::Chars

Motivation

While working on uuid_cli I realized that when an invalid character was provided in a namespace uuid for v3 and v5 variants, the expected characters is shown as a numeric array instead of an array of chars. Not helpful for users.

Tests

As its only a error message change, no tests needed

N/A

**I'm submitting a(n)** bug fix # Description Use string instead of `str::Chars` # Motivation While working on `uuid_cli` I realized that when an invalid character was provided in a namespace uuid for v3 and v5 variants, the expected characters is shown as a numeric array instead of an array of chars. Not helpful for users. # Tests As its only a error message change, no tests needed # Related Issue(s) N/A

Dylan-DPC-zz (Migrated from github.com) reviewed

2019-01-10 21:49:54 -06:00

KodrAus (Migrated from github.com) reviewed

2019-01-13 15:09:00 -06:00

KodrAus (Migrated from github.com) left a comment

No description provided.

Looks good to me!

KodrAus commented

2019-01-13 15:10:26 -06:00

(Migrated from github.com)

The build failure looks like a combination of formatting needed and wasm.

kinggoesgaming commented

2019-01-13 16:08:30 -06:00

(Migrated from github.com)

Ill get to it tonight 👍

Ill get to it tonight :+1:

kinggoesgaming commented

2019-01-17 15:38:26 -06:00

(Migrated from github.com)

awaiting on #358

KodrAus (Migrated from github.com) approved these changes

2019-01-17 15:50:38 -06:00

KodrAus (Migrated from github.com) left a comment

Looks good to me!

kinggoesgaming commented

2019-01-17 19:39:57 -06:00

(Migrated from github.com)

bors r+

bors[bot] commented

2019-01-17 19:57:46 -06:00

(Migrated from github.com)

Build succeeded

# Build succeeded * [continuous-integration/appveyor/branch](https://ci.appveyor.com/project/KodrAus/uuid/builds/21708219) * [continuous-integration/travis-ci/push](https://travis-ci.org/uuid-rs/uuid/builds/481161359?utm_source=github_status&utm_medium=notification)